Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagation support for bind mounts (once docker-py supports it officially) #494

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jannefleischer
Copy link

I added a pull request for propagation support in docker-py (docker/docker-py#3164) which has to be accepted before this PR makes any sense.

Also I just realized that there seem to be other options (Mount specs???) in dockerspawner to enable propagation, but since documentation of docker-py is sparse, I couldn't figure out how to use that...

This might be helpful for others that want to use autofs in their jupyter-container launched by dockerspawner.

@welcome
Copy link

welcome bot commented Aug 10, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jannefleischer
Copy link
Author

docker/docker-py#3164 has been merged via docker/docker-py@0f0b20a

`rshared`,`shared`,`rprivate`, `private`, `rslave`, `slave`.
default is `rprivate`.
This is only interpreted by docker-py if patched (see:
https://github.com/jannefleischer/docker-py/commit/786d55de465e72d0bb4b318272a2d020e43ff54a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it required a manual patch, I would not consider this patch appropriate for this project, but since it's merged, can you reference the required version of docker-py here? It's not clear to me what that is.

@minrk minrk added the new label Sep 18, 2023
@jannefleischer
Copy link
Author

jannefleischer commented Oct 10, 2023

Currently I am still waiting for a new release of docker-py (pypi | github). So any version after august 15, 2023 will hold the necessary patch. I will continue monitoring this and I'll let you know, once we have a version we can rely on.

@jannefleischer jannefleischer changed the title propagation support for bind mounts (if docker-py supports it) propagation support for bind mounts (once docker-py supports it officially) Oct 10, 2023
@jannefleischer jannefleischer marked this pull request as draft October 10, 2023 07:31
@jannefleischer
Copy link
Author

Just a heads up: From 7.0.0b2 and forward the propagation thingy is supported. - but its still pre-release.

@jannefleischer
Copy link
Author

jannefleischer commented Dec 11, 2023

docker-py 7.0 is published officially, which includes the support for propagation: https://github.com/docker/docker-py/releases/tag/7.0.0 - so this pr could be merged if a new dependency on docker-py 7.0.0 is ok.

@jannefleischer jannefleischer marked this pull request as ready for review December 11, 2023 11:09
bringing v4 back to my fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants