Added option to set msgtype for messages #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhsjdhjs
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Thank you for this neat addition! Also thanks for keeping the codestyle and documentation style consistent with the existing one!
The failing mypy check is unrelated, fixed in 4123d0e if you want to rebase. The changes look good to me aside that one comment 👍
|
I also merged your changes from the main branch, so I think it should be ready now. If I forgot something, let me know. Looking forward to the new release. |
jkhsjdhjs
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added config option to send messages as type m.text (normal message / default) or m.notice (bot message).
In my tests it worked without any problems, but I may have overlooked a few things.
Thanks for this great and simple plugin!