Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return of the build script via Preferences #483

Merged
merged 26 commits into from
Nov 3, 2022
Merged

Return of the build script via Preferences #483

merged 26 commits into from
Nov 3, 2022

Commits on Nov 1, 2022

  1. Add old builder script at a GRPrefrences submodule

    @mkitti
    mkitti committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    f00f8de View commit details
    Browse the repository at this point in the history

  2. Make sure deps directory is created

    @mkitti
    mkitti committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    0911720 View commit details
    Browse the repository at this point in the history

  3. Cleanup some old code

    @mkitti
    mkitti committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    351aa87 View commit details
    Browse the repository at this point in the history

  4. Refactor build.jl into downloader.jl

    @mkitti
    mkitti committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    2f41c77 View commit details
    Browse the repository at this point in the history

  5. Implement JLL overrides

    @mkitti
    mkitti committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    5322ba6 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Add a friendly suggestion to use force = true

    @mkitti
    mkitti committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    941b490 View commit details
    Browse the repository at this point in the history

  2. Use GR_jll's UUID rather than the GR_jll symbol in case GR_jll fails … 

    …to load
    @mkitti
    mkitti committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    3151f4f View commit details
    Browse the repository at this point in the history

  3. Add a force keyword to download

    @mkitti
    mkitti committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    c240f95 View commit details
    Browse the repository at this point in the history

  4. Add repair instructions to GR_jll import failure message.

    @mkitti
    mkitti committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    994807f View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Mostly style and conciseness

Co-authored-by: t-bltg <tf.bltg@gmail.com>
    @mkitti @t-bltg
    mkitti and t-bltg authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    1829619 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    More concise!

Co-authored-by: t-bltg <tf.bltg@gmail.com>
    @mkitti @t-bltg
    mkitti and t-bltg authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    a0f7240 View commit details
    Browse the repository at this point in the history

  7. Add diagnostics function

    @mkitti
    mkitti committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    6802ac6 View commit details
    Browse the repository at this point in the history

  8. Allow install_dir to include "gr" basename, use parent as install_dir

    @mkitti
    mkitti committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    5f6fc70 View commit details
    Browse the repository at this point in the history

  9. Reinitialize GRPreferences.jl after changing binaries

    @mkitti
    mkitti committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    fe6ccff View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Fix resolved_dir in diagnostics

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    6fc46ea View commit details
    Browse the repository at this point in the history

  2. Fix svgplugin.dll issues on Windows

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    833468e View commit details
    Browse the repository at this point in the history

  3. Pin GR_jll version to 0.69.1

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    9a74f89 View commit details
    Browse the repository at this point in the history

  4. Fix libpath on Windows, maybe?

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    38cb1c8 View commit details
    Browse the repository at this point in the history

  5. Add README documentation for GRPreferences

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    84c69ae View commit details
    Browse the repository at this point in the history

  6. Fix funcptrs.jl

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    2472394 View commit details
    Browse the repository at this point in the history

  7. Resolve svgplugin issues by rebuilding LIBPATH

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    ea529f5 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review

    @mkitti
    mkitti authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    fbbada0 View commit details
    Browse the repository at this point in the history

  9. Improve Overrides.toml diagnostic

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    1390e5d View commit details
    Browse the repository at this point in the history

  10. Rename get_override to get_overrides

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    9a82ca6 View commit details
    Browse the repository at this point in the history

  11. Add some GRPreferences tests

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    375a59f View commit details
    Browse the repository at this point in the history

  12. Fix tests

    @mkitti
    mkitti committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    005b721 View commit details
    Browse the repository at this point in the history