-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated screenshots for the user guide documentation of scaling jenkins on kubernetes #7606
Updated screenshots for the user guide documentation of scaling jenkins on kubernetes #7606
Conversation
Co-authored-by: Moldovan, Madalina WI/CBR-ZGP1 <moldomda@schaeffler.com>
…ng jenkins on kubernetes" This reverts commit 70dc24067490ee31f6649899ddc4192c311ac8f5.
This reverts commit 8b3cd0ed4461debc31d88105c0ff0d5f0f8870af.
This reverts commit 276defc.
@kmartens27 I think the build-job screenshot can be compressed further(I will use compressor.io I think pngcrush does not work) should I commit my changes in this branch only or should I open a new PR |
Hi @yashpal2104 please do not open another pull request for this work. #7598 is already open and contains most of the same changes being submitted here. If this PR is the one intended to be the complete fix, then #7598 needs to be closed in favor of this one. The work should be contained to the same branch if it has to do with the same updates being made. When you make commits in the same branch it can update the previous work done (depending on what has changed). If you compress the images again, please just update the images that are already contained in the directory. Pushing that commit will then update this PR with the new images and remove the old ones in the same process. Be sure to replace the current image(s) with the updated/more compressed version. |
Yeah ok I understand now, actually I made 2 PR because in the first PR I had not made a new branch from master and kris stern pointed it out and then the 2nd PR I made is this one which is a clean branch made from master. So I will close the 1st PR and commit the changes in this thank you for clarifying my doubt. |
No worries at all! I just want to make sure there is no/minimal confusion when it comes to the work being submitted and what should take priority. |
Yes thanks to you I am getting the hang of it |
@kmartens27 I think why this is failing the test cases is because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screenshots look good, thanks very much @yashpal2104
Fixes #7529 , updated the screenshots for the user guide of the scaling jenkins on kubernetes.