Updated screenshots for user guide documentation for the kubernetes-plugin using Jenkins #7597
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation to manage jenkins" This reverts commit e525070.
… into update-screenshots
kmartens27
requested changes
Oct 10, 2024
There was a problem hiding this comment.
It looks like the images were added to the incorrect directory. Here, they've been added to the managing directory within the resources directory. They should be in the scaling-jenkins-on-kubernetes directory so that the page will know where to find them.
Right now, the deploy site is showing them as broken images:
|
Oh my bad I will correct them. I am sorry I miss read the location of images directory in the kubernetes adoc file |
|
closing in favor of #7598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.