Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace locally-defined video playback constants #6232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rjb-tech
Copy link

Changes
This is a simple PR to replace constants in the video playback controller. The file had locally defined values for TICKS_PER_SECOND and TICKS_PER_MINUTE instead of using the constants exported from the shared constants/ directory. Basically just a little linting PR.

Issues

@rjb-tech rjb-tech requested a review from a team as a code owner October 20, 2024 23:58
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 20, 2024

Cloudflare Pages deployment

Latest commit 3bfc127
Status ✅ Deployed!
Preview URL https://dccd12f0.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@rjb-tech rjb-tech changed the title Replace locally-defined video playback Replace locally-defined video playback constants Oct 20, 2024
Copy link

sonarcloud bot commented Oct 20, 2024

@viown
Copy link
Member

viown commented Oct 21, 2024

Hey, I already included this change a while back in my prompt skip PR https://github.com/jellyfin/jellyfin-web/pull/6196/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants