Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tags and schedule edit for parental control #6231

Merged
merged 12 commits into from
Oct 20, 2024
Merged

Fix tags and schedule edit for parental control #6231

merged 12 commits into from
Oct 20, 2024
+75 −93

Commits on Oct 20, 2024

  1. Fix tags and schedule edit for parental control

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    956f9bf View commit details
    Browse the repository at this point in the history

  2. Don’t use FIXME

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    88f9c3d View commit details
    Browse the repository at this point in the history

  3. Use anchor for onClick

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    7eda53f View commit details
    Browse the repository at this point in the history

  4. Use button

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    84f7cf1 View commit details
    Browse the repository at this point in the history

  5. Unset button style

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    d9786d4 View commit details
    Browse the repository at this point in the history

  6. Add libraryMenu as dep

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    0ad0a61 View commit details
    Browse the repository at this point in the history

  7. Use index as key for access schedule 

    Unfortuenately, the key is never populated in accessSchedule.js which cannot use that as a key for a list
    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    3ae148f View commit details
    Browse the repository at this point in the history

  8. Fix lint

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    95e935a View commit details
    Browse the repository at this point in the history

  9. Use daysofweek and hours as key 

    This is better and any sane person should not set multiple schdules to be exactly the same
    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    bb17d58 View commit details
    Browse the repository at this point in the history

  10. Unbind event listeners when unmounting

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    5b687f6 View commit details
    Browse the repository at this point in the history

  11. Fix lint

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    a1acb57 View commit details
    Browse the repository at this point in the history

  12. Cleanup functions

    @gnattu
    gnattu committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    e17d50f View commit details
    Browse the repository at this point in the history