Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate webpack scripts to TypeScript #6189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joeykilpatrick
Copy link

Changes
Migrate webpack build scripts to TypeScript (webpack.*.js --> webpack.*.ts)
Adds ts-node as loader for webpack CLI

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

webpack.common.ts Outdated Show resolved Hide resolved
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 13, 2024

Cloudflare Pages deployment

Latest commit b6fff3b
Status ✅ Deployed!
Preview URL https://14e4ea4c.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Oct 16, 2024
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@joeykilpatrick
Copy link
Author

  1. I'm not sure how to get Github Actions to re-review now that eslint issue is fixed.
  2. The Sonarcloud failure is not related to this change, but I would be happy to add webpack.*.ts to the list of excluded files for that scan. Just looking for some feedback before I do that. I don't see a platform-independent way to address the issue.

@thornbill thornbill added this to the v10.11.0 milestone Oct 17, 2024
@thornbill
Copy link
Member

No worries. I'll take care of both of those. The review just has to be dismissed since the action doesn't update the status once issues are fixed and I can accept the issue in sonarcloud to clear that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants