Update to ESLint 9 #622
Merged
Update to ESLint 9 #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3flex
commented
Oct 20, 2024
| globals: { | ||
| $scope: 'writable', | ||
| cast: 'readonly' | ||
| } |
There was a problem hiding this comment.
I didn't understand the reason for including these items in the globals block, and a look at the commit history and a few searches online didn't help.
They have not been carried over to the new config.
nielsvanvelzen
approved these changes
Oct 20, 2024
|
The linter seems to run fine, we can always update the config later if any issues with it arise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm no expert here, so there may be some issues in the migration of the config file. The new config file format is very different to the old, and some things weren't clear in the ESLint config migration guide for v9, so it's possible that there are some unintended behaviour changes that have been introduced.
I've verified that the typescript checks are working which is probably the most important thing.