[WIP] [iOS] Admin Dashboard Enhancements #1271
Conversation
…ates after changes!
…. Remove leftover EditTaskTriggerView logic. Add Results/Errors to the EditScheduledTaskView. Track Progress on EditScheduledTaskView.
… struct. Creation of a ChevronInputButton object that probably needs some love...
…sizing for Albums Active Sessions
… BEFORE attempting to delete. Creation of an Admin Session Indicator for showing if there are active sessions from the HomeView. Fix Day of Week localization based on jellyfin#1255 (comment) - Confirmed working! Created an activeSessions published value for usage with the Active Sessions Indicator. Migration of the ChevronInputButton to allow more input types than just TextFields. Creation of a Users section. Grid vs Row User Section. Allow for User Password Resets. Make sure the DeviceType backgrounds never clash with the SVG. General cleanup of previous work mostly labels and formatting based on changes mentioned above. Finally, migrated ALL of the UserDashboard -> AdminDashboard (Since it's admin only now) and created it's own coordinator. Now available from the ActiveSessionsIndicator.
JPKribs
changed the title
JPKribs
changed the title
There was a problem hiding this comment.
This was more digestible when it was mainly task triggers and small work to devices, but now is getting too large for me to review effectively and make comments that apply to future work.
Apologies, butI ask that all new sections be implemented in their own PRs as they are quite independent of one another (sans xcodeproj conflicts). This would make my reviews of each section faster and more effective.
Sounds good. For now, a lot of the work builds on other items so I'm just getting this into a single branch. When I'm ready, I'm going to break this out into something more reviewable by section. |
|
Apologies for that! The primary goal for this branch was to just visibility. But, I completely agree. This is kind of a beast to look at. |
JPKribs
changed the title
|
I'm closing this out in favor of smaller, actually manageable PRs. Tracking for this will occur: |
Formerly
#1255
Issue
This is an extension of #1230
Summary
This PR is where I have a couple different branches living together. I need to split them out into more manageable PRs but I wanted to make this visible so it wasn't just me working in the shadows. All of the Goals below are in this branch with varying levels of polish. As items are done, I'll check them off below.
Goals
ActiveSessionsIndicator