Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform X supporting in README #780

Merged
merged 4 commits into from
May 21, 2024

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Mar 23, 2024

The X is the new brand for Twitter.

The X is the new brand for Twitter.

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz
Copy link
Contributor Author

utzcoz commented Mar 23, 2024

Hi @mattr- , could you help to review this PR? Thanks.

Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site might be x.com, but if you go there, the title of the page still says Twitter. 🤣
image

Let's add x to the list of supported icons, since that's a good change, but make some other slight changes to this PR. Much like X itself, I hesitate to go all in with this rebrand.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
utzcoz and others added 3 commits May 8, 2024 10:24
Co-authored-by: Matt Rogers <mattr-@github.com>
Co-authored-by: Matt Rogers <mattr-@github.com>
@utzcoz
Copy link
Contributor Author

utzcoz commented May 8, 2024

@mattr- Thanks for your reviewing, PTAL again.

Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 44d99bc into jekyll:master May 21, 2024
2 of 3 checks passed
jekyllbot added a commit that referenced this pull request May 21, 2024
@utzcoz utzcoz deleted the add-X-supporting-in-README branch May 21, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants