Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setup.py by pyproject.toml #450

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Dec 7, 2023

No description provided.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e69cff) 90.14% compared to head (f976c12) 90.20%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   90.14%   90.20%   +0.06%     
==========================================
  Files           6        6              
  Lines         284      286       +2     
  Branches       51       51              
==========================================
+ Hits          256      258       +2     
  Misses         12       12              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claudep
Copy link
Contributor Author

claudep commented Dec 7, 2023

Does anyone know how to not include __pycache__ directories when building with python -m build? It's a current blocker for this patch.

@claudep claudep force-pushed the pyproject branch 3 times, most recently from d99925e to 8080d19 Compare December 7, 2023 20:12
@merwok
Copy link

merwok commented Dec 7, 2023

That’s probably up to the build backend

@claudep
Copy link
Contributor Author

claudep commented Dec 7, 2023

I checked other packages using the simple build backend, but their packages don't include __pycache__ dirs, so...

@merwok
Copy link

merwok commented Dec 7, 2023

What is «the simple build backend»?
You are using setuptools, which is popular but complicated.
flit-core is a simple build backend, hatchling too I think.
(pypa/build is a build frontend, it does not control the wheel build itself)

@@ -1,5 +0,0 @@
include *.txt *.py *.rst setup.cfg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this file?

global-exclude */__pycache__/*
global-exclude *.pyc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR that made no differences at all in the build result.

@claudep
Copy link
Contributor Author

claudep commented Jan 3, 2024

I think this is now ready. @Natim, is this OK for you?

@claudep claudep merged commit 3f90ac9 into jazzband:master Feb 3, 2024
11 checks passed
@claudep claudep deleted the pyproject branch February 3, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants