add chat.getThreadMessages #233
Conversation
Adds the Get Thread Messages call, https://developer.rocket.chat/reference/api/rest-api/endpoints/messaging/chat-endpoints/getthreadmessage. The docs say the tlm query param is required, but it is not actually supported. Pull request in to rocketchat developer docs to correct, RocketChat/developer-docs#196 Test: Post one message and two replies, then get thread messages. Check count of messages and their text.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi I see this failed on a test that already existed (tests/test_chat.py::test_chat_get_message_read_receipts) with licensing problems ('error': 'This is an enterprise feature [error-action-not-allowed]', 'errorType': 'error-action-not-allowed'). This happened when I tested it locally but I saw merged PR #210 that added an enterprise key, so I assumed (hoped?) it would work in the github workflow. Did I do something to screw this up/Is there anything I can do here, or is this simply just a licensing issue that needs to get sorted with RocketChat? |
|
Unfortunately, I have yet to figure out how to use the secrets on PRs made from forks on github actions. Changes LGTM. |
Adds the Get Thread Messages call. I followed what looked to be the pattern of expanding parameters into underscores between lowercase words (e.g.
tmid=thread_msg_id)Note: The docs say the
tlmquery parameter is required, but it is not actually supported. I have a pull request in to rocketchat developer docs to correct, RocketChat/developer-docs#196I made a pretty simple test, at least to start: it posts one message and two replies, then gets thread messages. Checks count of messages and their text. And the
successfield. I tested this with the docker setup in this repo - it was very easy, thank you!Is that sufficient, or do you usually like to check more of the message details or have other handling in there?