Skip to content

Commit

Permalink
squash w/ 182. code review - docs
Browse files Browse the repository at this point in the history
  • Loading branch information
korydraughn committed Jul 22, 2024
1 parent eda139c commit 14ce2df
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -429,9 +429,9 @@ The following arguments are strictly optional and may be used either in `Query`'
- The `case_sensitive` constructor parameter is ignored.
- The `options` constructor parameter is ignored.
- The `total_rows` member function of the `Query` class always returns `None`.
* *order_by* is a string holding the sorting instructions for a GenQuery2 query. Defaults to an empty string. Only used by the GenQuery2 parser.
* *order_by* is a string holding the sorting instructions for a GenQuery2 query. Defaults to an empty string. Only recognized by the GenQuery2 parser.

As a best practice, when using GenQuery2, prefer calling the `close()` member function when done processing the resultset. Doing this will instruct the server to immediately free any resources allocated to the `Query` object. This is extremely important when multiple `Query` objects are executed within a single rule.
When a GenQuery2 resultset is done being processed, it is best practice to call the `close()` member function. Doing this will instruct the server to immediately free any resources allocated to the `Query` object. This is extremely important when multiple `Query` objects are executed within a single rule.

# Questions and Answers

Expand Down
4 changes: 2 additions & 2 deletions genquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ class Query(object):
:param limit: (optional) maximum amount of results, can be used for pagination
:param case_sensitive: (optional) set this to False to make the entire where-clause case insensitive
:param options: (optional) other OR-ed options to pass to the query (see the Option type above)
:param parser: (optional) the GenQuery engine to use. defaults to Parser.GENQUERY1.
:param order_by: (optional) order-by clause, as a string. defaults to an empty string. applies when using the GenQuery2 parser
:param parser: (optional) the GenQuery engine to use. defaults to Parser.GENQUERY1
:param order_by: (optional) order-by clause, as a string. defaults to an empty string. only recognized by the GenQuery2 parser
GenQuery2 parser:
Expand Down

0 comments on commit 14ce2df

Please sign in to comment.