Skip to content

Commit

Permalink
patch #44
Browse files Browse the repository at this point in the history
  • Loading branch information
MartinSchobben authored and trel committed Nov 20, 2023
1 parent a6d6408 commit c570309
Show file tree
Hide file tree
Showing 15 changed files with 469 additions and 279 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@
^Meta$
^cran-comments\.md$
^CRAN-SUBMISSION$
^revdep$
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
.Rproj.user
docs
inst/doc
dev/
dev
!dev/Makefile
*.irods
/doc/
/Meta/
NEWS.md
CRAN-SUBMISSION
revdep/
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: rirods
Title: R Client for 'iRODS'
Version: 0.1.1.9000
Version: 0.1.2
Authors@R: c(
person("Martin", "Schobben", , "schobbenmartin@gmail.com",
role = c("aut", "cre", "cph"),
Expand Down
8 changes: 7 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
# rirods (development version)
# rirods 0.1.2

* Adding more documentation as vignettes:
+ Use iRODS demo
+ rirods vs iCommands
+ Accessing data locally and in iRODS
+ Use iRODS metadata

# rirods 0.1.1

Expand Down
19 changes: 13 additions & 6 deletions R/irods-demo.R
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,13 @@ use_irods_demo <- function(user = character(), pass = character(),

resp_user <- TRUE
if (length(irods_images) == 0 ||
!all(grepl(paste0(irods_images_ref, collapse = "|"), irods_images))) {
!all(grepl(paste0(irods_images_ref, collapse = "|"), irods_images))
) {
message("\nThe iRODS demo Docker containers are not built on this system. \n")
resp_user <-
utils::askYesNo("Would you like it to be built?", default = FALSE)
if (interactive()) {
resp_user <-
utils::askYesNo("Would you like it to be built?", default = FALSE)
}
}

# launch irods_demo
Expand Down Expand Up @@ -151,9 +154,13 @@ remove_docker_images <- function() {
stop("Docker containers are still running. Stop them with ",
"`stop_irods_demo()` and proceed", call. = FALSE)
}
system2(
system.file(package = "rirods", "shell_scripts", "docker-images-remove.sh"),
paste0(irods_images_ref, collapse = ", ")
bsh <-
system.file(package = "rirods", "shell_scripts", "docker-images-remove.sh")
Map(
function(x) {
system2(bsh, x, stderr = NULL)
},
irods_images_ref
)
invisible()
}
Expand Down
2 changes: 1 addition & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ use_irods_demo("alice", "passWORD")
unlink(rirods:::path_to_irods_conf())
```

This will result in the demonstration REST API running at http://localhost/irods-rest/0.9.3 (or later version).
This will result in the demonstration REST API running at `http://localhost/irods-rest/0.9.3` (or later version).

These Docker containers are designed to easily stand up a **DEMONSTRATION** of the iRODS server. It is intended for education and exploration. (See also `vignette("demo")`.)

Expand Down
Loading

0 comments on commit c570309

Please sign in to comment.