[irods#6286] catch all exceptions.(4-2-stable) #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even nlohmann::json errors will be caught and logged in an informative way, since the embedded message conveys their code and type.
alanking
reviewed
Apr 4, 2022
| rodsLog(LOG_ERROR,"Unknown error in FILE %s LINE %d FUNCTION %s ", | ||
| __FILE__,__LINE__,__FUNCTION__); | ||
| return ERROR( | ||
| SYS_NOT_SUPPORTED, |
There was a problem hiding this comment.
Same here about SYS_UNKNOWN_ERROR
| rodsLog(LOG_ERROR,"std::exception (%s) in FILE %s LINE %d FUNCTION %s ", | ||
| _e.what(),__FILE__,__LINE__,__FUNCTION__); | ||
| return ERROR( | ||
| SYS_NOT_SUPPORTED, |
There was a problem hiding this comment.
Same here about SYS_INTERNAL_ERR
| rodsLog(LOG_ERROR,"std::exception (%s) in FILE %s LINE %d FUNCTION %s ", | ||
| _e.what(),__FILE__,__LINE__,__FUNCTION__); | ||
| return ERROR( | ||
| SYS_NOT_SUPPORTED, |
There was a problem hiding this comment.
Can we make this SYS_INTERNAL_ERR? This is the convention I had been following when working on other things. If you feel this error code is more appropriate in this situation, then let's stick with that. :)
| rodsLog(LOG_ERROR,"Unknown error in FILE %s LINE %d FUNCTION %s ", | ||
| __FILE__,__LINE__,__FUNCTION__); | ||
| return ERROR( | ||
| SYS_NOT_SUPPORTED, |
There was a problem hiding this comment.
Can we make this SYS_UNKNOWN_ERROR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even nlohmann::json errors will be caught and logged in an informative
way, since the embedded message conveys their code and type.