feat: 'auto' option for runPubGetInParallel #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the new value of 'auto' to runPubGetInParallel, which is now default and will only run pub get sequentially if it's being run on a CI instance.
spydon
reviewed
Jun 19, 2024
|
|
|
Changed the docs to reflect the change, but tests are a bit more complicated cause I don't really understand how things are set up there and how everything interacts with each other just yet. I can take a deeper look into it during the week though. |
szugyi
reviewed
Jul 1, 2024
| @@ -183,7 +183,7 @@ dependencyOverridePaths: | |||
|
|
|||
| Whether to run `pub get` in parallel during bootstrapping. | |||
|
|
|||
| The default is `true`. | |||
| The default is `auto`, which fallbacks to `false` if the machine is a CI instance. | |||
There was a problem hiding this comment.
If this change will make into main, I would suggest adding explanation to this line. Why is this the default, what is the issue it resolves, and what could someone who changes this to true expect.
There was a problem hiding this comment.
Can you look into that @tomassasovsky?
|
@tomassasovsky any updates on this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the new value of 'auto' to
runPubGetInParallel, which is now default and will only run pub get sequentially if it's being run on a CI instance.Since the current variable type is of
boolfor this variable, I had to add some code to handle both the old and new possible data types for parsing. Any alternative ideas for this are more than welcome.PS: thanks for making such an awesome tool!
Closes #546
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore