-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Mention changelogCommitBodies
and add IntelliJ schema settings guide
#721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small comment
docs/ide-support.mdx
Outdated
|
||
### `melos.yaml` | ||
|
||
Autocompletion and validation of `melos.yaml` can be enabled in IntelliJ by going to `Settings` > `Languages & Frameworks` > `Schemas and DTDs` > `JSON Schema Mappings` and adding the Melos schema: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you wrap this so that the line length is <80?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
docs/ide-support.mdx
Outdated
### `melos.yaml` | ||
|
||
Autocompletion and validation of `melos.yaml` can be enabled in IntelliJ by going to | ||
`Settings` > `Languages & Frameworks` > `Schemas and DTDs` > `JSON Schema Mappings` and adding the Melos schema: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still longer than 80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, true
changelogCommitBodies
, add IntelliJ schema settings guidechangelogCommitBodies
and add IntelliJ schema settings guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I've noticed the images does not get shown, I guess mdx does not support Is there a way by the way to build the docs locally? I did not find a way |
Ah, I missed this, you can preview your changes on https://melos.invertase.dev/~721 |
Thx, I'll add it to Contributing.md guide |
Description
#606
changelogCommitBodies
change is great, needed it badly so glad it exists, however is missing in the docsI am regular IntelliJ user and having schema is a must have, so I added a small guide how to get it.
Btw the https://github.com/blaugold/melos-code/pulls repo has some PRs to review
Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore