Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create browse communities page #2861

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

carlinmack
Copy link
Contributor

❤️ Thank you for your contribution!

Close zenodo/zenodo-rdm#990

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@pass_community(serialize=True)
def communities_browse(pid_value, community, community_ui):
"""Community browse page."""
permissions = community.has_permissions_to(MEMBERS_PERMISSIONS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the required permission for the browse page? I am lacking context on why MEMBERS_PERMISSIONS is used here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to avoid jinja2.exceptions.UndefinedError: 'permissions' is undefined. I'm not sure what to pass instead?

invenio_app_rdm/communities_ui/views/ui.py Outdated Show resolved Hide resolved
invenio_app_rdm/config.py Outdated Show resolved Hide resolved
@alejandromumo alejandromumo merged commit fda3016 into inveniosoftware:master Sep 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subcommunities & browse pages
2 participants