Deposit form: Provide props to overridable components #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenekku
approved these changes
Aug 26, 2024
invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/RDMDepositForm.js
Show resolved
Hide resolved
* some of the overridable components have been using values that weren't passed as props
max-moser
force-pushed
the
mm/overridables-props
branch
from
e89f38d
to
da05c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the
<Overridable>components have been using values that weren't passed as props.This makes it hard to provide overrides for those components that are functionally the same.
For example, I am writing an override for the
InvenioAppRdm.Deposit.CardDepositStatusBox.containerforInvenio-Curationswhich adds a section for the curation review request.Without passing the props, this override couldn't access the
props.permissionswhich is used by the default component to enable/disable some buttons.With the props being passed, I can use it as expected:
