migration: account for deleted communities and draft concept DOI

inveniosoftware · Aug 30, 2024 · 8e0903d · 8e0903d
1 parent 8205056
commit 8e0903d
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/invenio_app_rdm/upgrade_scripts/migrate_11_0_to_12_0.py b/invenio_app_rdm/upgrade_scripts/migrate_11_0_to_12_0.py
@@ -59,10 +59,12 @@ def execute_upgrade():
     """
 
     def migrate_review_policy(community_record):
-        review_policy = community_record["access"].get(
+        if community_record.is_deleted:
+            return
+
+        community_record["access"].setdefault(
             "review_policy", ReviewPolicyEnum.CLOSED.value
         )
-        community_record["access"]["review_policy"] = review_policy
 
     def update_parent(record):
         """Update parent schema and parent communities for older records."""
@@ -94,12 +96,13 @@ def update_parent(record):
                     record.parent, pids
                 )
                 record.parent["pids"] = pids
-                current_rdm_records.records_service.pids.register_or_update(
-                    id_=record["id"],
-                    identity=system_identity,
-                    scheme="doi",
-                    parent=True,
-                )
+                if isinstance(record, RDMRecord):
+                    current_rdm_records.records_service.pids.register_or_update(
+                        id_=record["id"],
+                        identity=system_identity,
+                        scheme="doi",
+                        parent=True,
+                    )
 
     def update_record(record):
         # skipping deleted records because can't be committed