Make Explorer Find widget work in 1.94 as long as proposed APIs are enabled (fix #1443) #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Explorer Find remains broken for folders that use queryparams. This is almost certainly the same as #1427. |
|
1.94's new dependency on FileSearchProvider has been raised at microsoft/vscode#230483 |
isc-bsaviano
reviewed
Oct 4, 2024
| filter = `Name LIKE '%${pattern.replace(/(_|%|\\)/g, "\\$1")}%' ESCAPE '\\'`; | ||
| } else { | ||
| filter = `Name LIKE '%${pattern}%'`; | ||
| pattern = pattern.replace(/(_|%|\\)/g, "\\$1"); |
There was a problem hiding this comment.
Why not always do this replacement and provide the ESCAPE clause? I doubt it impacts performance significantly and it makes this code shorter:
filter = `Name LIKE '%${pattern.replace(/(_|%|\\)/g, "\\$1").replace(/\*/g, "%").replace(/\?/g, "_")}%' ESCAPE '\\'`
isc-bsaviano
approved these changes
Oct 4, 2024
|
This looks good, assuming there are no globstars outside the possible leading one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1443 which occurs on VS Code 1.94+
A separate issue is that the Explorer Find widget now depends on FileSearchProvider. I will raise this with the VS Code project.