Improvements to attach-type debugging #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some improvements to the type of debugging in which you attach to a running process on a server.
It adds an entry to "initialConfigurations" in package.json so users setting up debugging in a workspace or folder for the first time won't have to add an attach-type configuration manually.
It also makes attach-type debugging usable when no documents are open from the server. In this case, if the workspace is multi-root the user must select a folder before being offered the process picker.
In conjunction with the new "always pause the attached process" behaviour (#1415) this means it is no longer necessary to open a document from the target namespace before being able to attach and debug a running process.