Windows linux AI, and ICO updates to c4 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For examples\gcp-rhel-vm: Had to remove local versions.tf due to conflict of older version with root\version.tf thus just deleted the local versions.tf as it is not needed. After this was done - example VALIDATED. For examples\gcp-windows-vm: Had to remove local versions.tf due to conflict of older version with root\version.tf thus just deleted the local versions.tf as it is not needed. After this was done - example VALIDATED. For examples\gcp-windows-vm-ico-by-densify: variables.tf needed to be modified to set recommendedType = "c4-standard-4"- these changes were also don on readme.md, densify_recommendation.auto.tvars files - VALIDATED. For examples\gcp-linux-vm-ico-by-densify: variables.tf needed to be modified to set recommendedType = "c4-standard-4"- these changes were also don on readme.md, densify_recommendation.auto.tvars files - VALIDATED.
…r C4 Updated all of the AI, TDX, and ICO modules and readme with update for C4
github-actions
bot
added
documentation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
examples/gcp-windows-vm/versions.tf
Outdated
There was a problem hiding this comment.
Did you mean to delete this file? Just checking.
examples/gcp-rhel-vm/README.md
Outdated
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| ## Intel Red Hat Enterprise Linux GCP VM Example | |||
|
|
|||
| This module creates a Red Hat Enterprise Linux (RHEL) VM on the Intel Sapphire Rapids CPU. The virtual machine is created on an Intel Sapphire Rapids c3-standard-4 by default. | |||
| This module creates a Red Hat Enterprise Linux (RHEL) VM on the Intel 5th Gen Emerald Rapids CPU. The virtual machine is created on an Intel Sapphire Rapids c3-standard-4 by default. | |||
There was a problem hiding this comment.
Should we change this "Intel Sapphire Rapids c3-standard-4"?
There was a problem hiding this comment.
It's should say c4-standard-4 by default- Emerald Rapids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
This updates both main.tf and readme files for AI and ICO examples for C4 instance
PR Type
enhancement, documentation
Description
c4series for improved performance.versions.tffiles to resolve version conflicts.recommendedTypesettings in ICO examples to align with new machine types.Changes walkthrough 📝
7 files
main.tf
Update machine type to c4-standard-32 in FastChat exampleexamples/gcp-linux-fastchat-simple/main.tf
machine_typetoc4-standard-32.main.tf
Update machine type to c4-standard-32 in Stable Diffusion exampleexamples/gcp-linux-stable-diffusion/main.tf
machine_typetoc4-standard-32.main.tf
Update machine type to c4-standard-4 in TDX VM exampleexamples/gcp-linux-tdx-vm/main.tf
machine_typetoc4-standard-4.variables.tf
Update recommendedType to c4-standard-4 in Linux VM ICO exampleexamples/gcp-linux-vm-ico-by-densify/variables.tf
recommendedTypetoc4-standard-4.variables.tf
Update recommendedType to c4-standard-4 in Windows VM ICO exampleexamples/gcp-windows-vm-ico-by-densify/variables.tf
recommendedTypetoc4-standard-4.densify_recommendations.auto.tfvars
Update recommendedType in Linux VM ICO auto.tfvarsexamples/gcp-linux-vm-ico-by-densify/densify_recommendations.auto.tfvars
recommendedTypetoc4-standard-4.densify_recommendations.auto.tfvars
Update recommendedType in Windows VM ICO auto.tfvarsexamples/gcp-windows-vm-ico-by-densify/densify_recommendations.auto.tfvars
recommendedTypetoc4-standard-4.2 files
versions.tf
Remove local versions.tf file in RHEL VM exampleexamples/gcp-rhel-vm/versions.tf
versions.tffile.versions.tf
Remove local versions.tf file in Windows VM exampleexamples/gcp-windows-vm/versions.tf
versions.tffile.7 files
main.tf
Correct comment for firewall rules in AI OPEA Codegen exampleexamples/gen-ai-xeon-opea-codegen/main.tf
README.md
Update processor generation in FastChat READMEexamples/gcp-linux-fastchat-simple/README.md
README.md
Update processor generation in Stable Diffusion READMEexamples/gcp-linux-stable-diffusion/README.md
README.md
Update processor generation in TDX VM READMEexamples/gcp-linux-tdx-vm/README.md
README.md
Update recommendedType in Linux VM ICO READMEexamples/gcp-linux-vm-ico-by-densify/README.md
recommendedTypetoc4-standard-4.README.md
Update processor generation in RHEL VM READMEexamples/gcp-rhel-vm/README.md
README.md
Update recommendedType in Windows VM ICO READMEexamples/gcp-windows-vm-ico-by-densify/README.md
recommendedTypetoc4-standard-4.