Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Implement the rest of geometric built-ins #8718

Merged
merged 4 commits into from
Apr 11, 2023
Merged

[SYCL] Implement the rest of geometric built-ins #8718

merged 4 commits into from
Apr 11, 2023

Conversation

KornevNikita
Copy link
Contributor

No description provided.

@KornevNikita KornevNikita requested a review from a team as a code owner March 21, 2023 15:55
@KornevNikita KornevNikita marked this pull request as draft March 21, 2023 15:55
@KornevNikita
Copy link
Contributor Author

It's just the initial version, so there are some more things to do:

  1. May be we should unite to_vec() & to_marray(), but for some reason std::memcpy() doesn't work in to_marray(), may be I'm just doing something wrong.
  2. Probably all of these built-ins may be replaced by one common #define.
  3. Also, I'm wondering if there should be host implementations like in https://github.com/intel/llvm/blob/sycl/sycl/source/detail/builtins_geometric.cpp?

@KornevNikita
Copy link
Contributor Author

E2E: intel/llvm-test-suite#1673

@KornevNikita KornevNikita temporarily deployed to aws March 21, 2023 19:49 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to aws March 21, 2023 23:59 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to aws April 5, 2023 12:58 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov marked this pull request as ready for review April 10, 2023 22:29
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 10, 2023 23:20 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 10, 2023 23:30 — with GitHub Actions Inactive
maarquitos14
maarquitos14 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

steffenlarsen
steffenlarsen reviewed Apr 11, 2023
View reviewed changes
sycl/include/sycl/builtins.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/builtins.hpp Outdated Show resolved Hide resolved
steffenlarsen
steffenlarsen approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 11, 2023 13:56 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws April 11, 2023 13:57 — with GitHub Actions Inactive
@AlexeySachkov AlexeySachkov merged commit a7a6de2 into intel:sycl Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm-vodopyanov dm-vodopyanov dm-vodopyanov left review comments

@maarquitos14 maarquitos14 maarquitos14 approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KornevNikita @dm-vodopyanov @maarquitos14 @steffenlarsen @AlexeySachkov