Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][Matrix]Add test for all sizes #1628

Draft
wants to merge 10 commits into
base: intel
Choose a base branch
from

Conversation

YuriPlyakhin
Copy link

No description provided.

@YuriPlyakhin YuriPlyakhin requested a review from a team as a code owner March 2, 2023 20:23
Copy link

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should add the XMX8 version of the test so it gets tested on ATS-M as well

Updated tests to pass on GPU, splitting compilation of each kernel.
Added new environment variables for different optimization modes
Added XMX8 variant.
Copy link

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the way it was with having multiple tests rather than macros. what do you think?
It is okay to set it to xfail until we fix the bug

@YuriPlyakhin YuriPlyakhin marked this pull request as draft March 13, 2023 15:56
Copy link

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkhaldi dkhaldi marked this pull request as ready for review March 16, 2023 18:00
@YuriPlyakhin YuriPlyakhin marked this pull request as draft March 16, 2023 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants