Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade ical-generator to v4.1.0 #1005

Merged

Conversation

make-github-pseudonymous-again
Copy link
Contributor

ical-generator v5 does not officially support Node v14 (https://github.com/sebbo2002/ical-generator/releases/tag/v5.0.0).

@make-github-pseudonymous-again make-github-pseudonymous-again added dependencies Pull requests that update a dependency file feature/agenda This issue is about the agenda functionality deps This issue has to do with dependencies labels Jun 4, 2024
@make-github-pseudonymous-again make-github-pseudonymous-again changed the title Downgrade ical-generator to v4.1.0 Downgrade ical-generator to v4.1.0 Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.28%. Comparing base (5377aef) to head (b45c543).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
- Coverage   66.30%   66.28%   -0.02%     
==========================================
  Files         719      719              
  Lines       10006    10006              
  Branches     1349     1349              
==========================================
- Hits         6634     6632       -2     
- Misses       2913     2915       +2     
  Partials      459      459              
Flag Coverage Δ
client 45.85% <ø> (-0.01%) ⬇️
server 62.62% <ø> (-0.02%) ⬇️
test 72.55% <ø> (-0.04%) ⬇️
test-app 53.72% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review June 4, 2024 23:01
Merged via the queue into main with commit a24a1b7 Jun 5, 2024
35 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the deps-downgrade-ical-generator-v4.1.0-1 branch June 5, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deps This issue has to do with dependencies feature/agenda This issue is about the agenda functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant