Initial power control for hubs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKevinWeiss
force-pushed
the
pr/powerctrl
branch
from
c454da9
to
6a9a4af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements some basic power control using
uhubctland specific compatible usb hubs.So far it is only implemented for the commissioner and the update_cache since both of these would need to power on to check.
Probably some cleanup and testing can be done but we need to start somewhere.
The
DEFAULT_MAX_ALLOWED_NODEShad been set to 14 as real experiments with boards showed bandwidth limitations between 7 (worst case) and 21 (best case).Only if a location has been setup with power control then it would be used, however, if no locations are set there should be no calls to uhubctl, thus developers should have no impact.