Some fixes for location and add location cache #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to run the CI manually due to inactivity but it passed... I can probably simplify the fake board output even more since we don't ever search for basic usb subtypes anymore but for now it is fine. Likely many changes will be coming up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the power control (not a simple thing with the current structure), I am adding some location caching that allows the current locations to be saved.
It is just a mapping from id, location state, and usb id_path. With this info it should not be hard to find out node info or location info stored in the config files.
Since powering on devices takes a while ~10 seconds to fully enumerate, we will need this in order to do quick checks or inventory polls. The only issue would be removing or adding a board should be followed with an update. The boards that are used would be powered anyways and can be determined by the lockfiles.