Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uri to require list for ruby 3.4 #154

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

getty104
Copy link
Member

Ruby 3.4 does not support uri modules by default.
This PR is for adopting this update.

Ref

https://github.com/increments/qiita-markdown/actions/runs/7704576731/job/20997185179?pr=153

# NameError:
#   uninitialized constant Qiita::Markdown::Transformers::FilterIframe::URI
#   ./lib/qiita/markdown/transformers/filter_iframe.rb:46:in `host_of'

Copy link

codeclimate bot commented Jan 30, 2024

Code Climate has analyzed commit 1c189a1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 98.9% (0.0% change).

View more on Code Climate.

Copy link
Member

@wataru86 wataru86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@getty104 getty104 merged commit f310fa9 into master Jan 30, 2024
9 checks passed
@getty104 getty104 deleted the add-uri-for-ruby-3.4 branch January 30, 2024 02:13
@getty104 getty104 mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants