Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github-linguist from 4.x to 7.x #150

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Upgrade github-linguist from 4.x to 7.x #150

merged 1 commit into from
Apr 5, 2024

Conversation

maedana
Copy link
Contributor

@maedana maedana commented Jan 8, 2024

I have trouble to install 1.6.x of rugged. The following error has occurred.

Installing rugged 1.6.3 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.                                                     
                                                                                                                       
    current directory: /home/maedana/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/rugged-1.6.3/ext/rugged            
/home/maedana/.rbenv/versions/3.2.2/bin/ruby extconf.rb --use-system-libraries                                         
checking for gmake... no                                                                                               
checking for make... yes                                                                                               
Building Rugged using system libraries.                                                                                
libgit2 version is not compatible, expected ~> 1.6.0                                                   
...

The latest version of rugged is 1.7.x. I could work around this by bringing github-linguist up to date.
The following PR solved the problem in my environment, and I confirmed that RSpec also passes.

maedana
maedana commented Jan 8, 2024
View reviewed changes
lib/qiita/markdown/filters/code_block.rb
@@ -86,7 +86,7 @@ def has_only_filename?
end

def linguist_language
@linguist_language ||= Linguist::Language.find_by_filename(filename).first
@linguist_language ||= Linguist::Language.find_by_extension(filename).first
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also github-linguist/linguist@v4.8.18...v5.0.0

@kyntk kyntk requested review from a team and mziyut and removed request for a team January 9, 2024 01:55
mziyut
mziyut approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@mziyut mziyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for your contribution!

@mziyut
Copy link
Contributor

mziyut commented Jan 12, 2024

Sorry, I recognized that there is a compatibility issue. I will check this pull request again.

@inukai-masanori inukai-masanori self-requested a review April 5, 2024 08:39
inukai-masanori
inukai-masanori approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@inukai-masanori inukai-masanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are very sorry for the delay in confirmation.
I have checked again and found that there is no problem.
Thank you very much.
LGTM!

@inukai-masanori inukai-masanori merged commit a11865f into increments:master Apr 5, 2024
7 checks passed
@Umekawa Umekawa mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mziyut mziyut mziyut approved these changes

@inukai-masanori inukai-masanori inukai-masanori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maedana @mziyut @inukai-masanori