Merge pull request #155 from increments/allow-open-attribute-in-details

Allow open attribute on details
increments · Mar 28, 2024 · b690b69 · b690b69
2 parents b9aacb6 + 89ef8c4
commit b690b69
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/lib/qiita/markdown/filters/final_sanitizer.rb b/lib/qiita/markdown/filters/final_sanitizer.rb
@@ -63,6 +63,9 @@ class FinalSanitizer < ::HTML::Pipeline::Filter
             "th" => [
               "style",
             ],
+            "details" => [
+              "open",
+            ],
             "video" => %w[
               src
               autoplay

diff --git a/lib/qiita/markdown/filters/user_input_sanitizer.rb b/lib/qiita/markdown/filters/user_input_sanitizer.rb
@@ -16,6 +16,7 @@ class UserInputSanitizer < ::HTML::Pipeline::Filter
             "blockquote" => %w[cite] + Embed::Tweet::ATTRIBUTES,
             "code" => %w[data-metadata],
             "div" => %w[class data-type data-metadata],
+            "details" => %w[open],
             "font" => %w[color],
             "h1" => %w[id],
             "h2" => %w[id],

diff --git a/spec/qiita/markdown/processor_spec.rb b/spec/qiita/markdown/processor_spec.rb
@@ -1067,6 +1067,11 @@
             puts "Hello, World"
             ```
             </div></details>
+
+            <details open close><summary>Folding sample2</summary>
+
+            it allows open attributes
+            </details>
           MARKDOWN
         end
 
@@ -1076,6 +1081,9 @@
             <div class="code-frame" data-lang="rb"><div class="highlight"><pre class="codehilite"><code><span class="nb">puts</span> <span class="s2">"Hello, World"</span>
             </code></pre></div></div>
             </div></details>
+            <details open><summary>Folding sample2</summary>
+            <p>it allows open attributes</p>
+            </details>
           HTML
         end
       end