Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes unused gem resque-bus #103

Merged
merged 5 commits into from
Dec 27, 2023
Merged

removes unused gem resque-bus #103

merged 5 commits into from
Dec 27, 2023

Conversation

vkghub
Copy link
Contributor

@vkghub vkghub commented Dec 26, 2023 •
edited
Loading

@vkghub vkghub marked this pull request as ready for review December 26, 2023 16:56
@vkghub vkghub self-assigned this Dec 26, 2023
@saikumar9 saikumar9 requested a review from TreyE December 26, 2023 17:07
@saikumar9 saikumar9 changed the title remove unused gem resque-bus removes unused gem resque-bus Dec 26, 2023
@saikumar9 saikumar9 enabled auto-merge (squash) December 26, 2023 17:16
saikumar9
saikumar9 reviewed Dec 26, 2023
View reviewed changes
Copy link
Member

@saikumar9 saikumar9 left a comment •
edited by vkghub
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkghub I think we should delete the file lib/event_source/tasks/event_source.rake which is related to the gem resque-bus. Please confirm.

@saikumar9 I think it is not required, I will remove.

raghuramg
raghuramg approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@raghuramg raghuramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikumar9 saikumar9 merged commit e2cb69b into trunk Dec 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TreyE TreyE TreyE approved these changes

@raghuramg raghuramg raghuramg approved these changes

@saikumar9 saikumar9 Awaiting requested review from saikumar9

Assignees

@vkghub vkghub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkghub @TreyE @raghuramg @saikumar9