Fix Append Transformation Edge Cases #595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
dev
before they can be merged tomaster
)Description
The append transform wasn't handling newlines correctly. Newlines in the middle of a file would cause datatools to stop processing right there, causing problems.
I'm not entirely sold on the solution I've found here of creating a second file to store the non-newlined text contents. My thinking was this was more stable than relying on memory (imagine an >100mb text file, which happens!)