Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Append Transformation #592

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Add Append Transformation #592

merged 3 commits into from
Apr 1, 2024

Conversation

miles-grant-ibigroup
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Adds new transformation type similar to replace transformation that appends to file instead of replaces. Appending is done in temporary dir. Unit test is included

@miles-grant-ibigroup miles-grant-ibigroup mentioned this pull request Mar 26, 2024
Merged
7 tasks
br648
br648 reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not far off. I think it should be able to handle the missing starting new line character, see comment.

src/main/java/com/conveyal/datatools/manager/models/transform/AppendToFileTransformation.java Outdated Show resolved Hide resolved
src/test/java/com/conveyal/datatools/manager/jobs/ArbitraryTransformJobTest.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/models/transform/AppendToFileTransformation.java Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/models/transform/AppendToFileTransformation.java Show resolved Hide resolved
src/test/java/com/conveyal/datatools/manager/jobs/ArbitraryTransformJobTest.java Show resolved Hide resolved
@br648 br648 assigned miles-grant-ibigroup and unassigned br648 Mar 27, 2024
@miles-grant-ibigroup
Copy link
Contributor Author

Thanks all changes are addressed!

br648
br648 reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, just one item left to consider then I'll approve.

src/main/java/com/conveyal/datatools/manager/models/transform/AppendToFileTransformation.java Show resolved Hide resolved
@br648 br648 assigned miles-grant-ibigroup and unassigned br648 Mar 28, 2024
br648
br648 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good following feedback to comments.

JymDyerIBI
JymDyerIBI approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me.

@miles-grant-ibigroup miles-grant-ibigroup merged commit 8889e04 into dev Apr 1, 2024
6 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the append-transformation branch April 1, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@br648 br648 br648 approved these changes

@JymDyerIBI JymDyerIBI JymDyerIBI approved these changes

Assignees

@JymDyerIBI JymDyerIBI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @br648 @JymDyerIBI