Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EU countries #64

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

VincentLanglet
Copy link
Contributor

Hi @dannyvankooten,

The EU country list is missing Overseas Departments and Territories.

These territories has country code, you can find them in Countries::$data, on wikipedia or
https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/Intl/Resources/data/regions/en.php
but currently they are not in the getCountryCodeInEu method.

@dannyvankooten dannyvankooten merged commit 2744069 into ibericode:master Nov 23, 2023
4 checks passed
@dannyvankooten
Copy link
Member

Nice, thank you @VincentLanglet. I wonder how these work with regards to their VAT number, do they get the same prefix as their mainland country?

@VincentLanglet
Copy link
Contributor Author

Nice, thank you @VincentLanglet. I wonder how these work with regards to their VAT number, do they get the same prefix as their mainland country?

Yes

@dannyvankooten
Copy link
Member

Just perfect then 👍 thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants