Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voltage sensor to Loqed integration #128972

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Rijswijker
Copy link

This is my first PR, i don't know how to complete all the checklist items.

Breaking change

None

Proposed change

Voltage sensor added, as this sometimes provides more information than a percentage (in the case of rechargeable batteries).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Add voltage sensor
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Rijswijker

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 22, 2024 12:23
@home-assistant
Copy link

Hey there @mikewoudenberg, mind taking a look at this pull request as it has been labeled with an integration (loqed) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of loqed can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign loqed Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mikewoudenberg
Copy link
Contributor

Though your solution looks OK, I don't think this will work the way you expect it. If I look at the documentation for the local API I see there is a battery status update message, but it doesn't seem to contain the battery voltage. I'll run my integration in debug mode for a while to see whether this has been added without the docs being updated.

@Rijswijker
Copy link
Author

Hi @mikewoudenberg

When i request the api status page (http://10.10.10.58/status) i get this response:

{
   "battery_percentage":79,
   "battery_type":"NICKEL_METAL_HYDRIDE",
   "battery_type_numeric":1,
   "battery_voltage":10.391,
   "bolt_state":"day_lock",
   "bolt_state_numeric":2,
   "bridge_mac_wifi":"ecXXXXXXXXe8",
   "bridge_mac_ble":"ecXXXXXXXXea",
   "lock_online":1,
   "webhooks_number":1,
   "ip_address":"10.10.10.58",
   "up_timestamp":1728956368,
   "wifi_strength":79,
   "ble_strength":52
}

Maybe it was added in one of the latest firmware updates? I haven't had the lock for long, so don't know if it was different before.

@epenet epenet changed the title feature: Add voltage sensor to Loqed integration Add voltage sensor to Loqed integration Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants