-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voltage sensor to Loqed integration #128972
base: dev
Are you sure you want to change the base?
Conversation
Add voltage sensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Rijswijker
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @mikewoudenberg, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Though your solution looks OK, I don't think this will work the way you expect it. If I look at the documentation for the local API I see there is a battery status update message, but it doesn't seem to contain the battery voltage. I'll run my integration in debug mode for a while to see whether this has been added without the docs being updated. |
When i request the api status page (http://10.10.10.58/status) i get this response:
Maybe it was added in one of the latest firmware updates? I haven't had the lock for long, so don't know if it was different before. |
This is my first PR, i don't know how to complete all the checklist items.
Breaking change
None
Proposed change
Voltage sensor added, as this sometimes provides more information than a percentage (in the case of rechargeable batteries).
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: