Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config flow to Onkyo #117319

Open
wants to merge 117 commits into
base: dev
Choose a base branch
from

Conversation

Nebula83
Copy link

@Nebula83 Nebula83 commented May 12, 2024

Breaking change

Removes support for configuration by configuration.yml file.

Proposed change

It updates the Onkyo integration to use config flow for setup, supporting manual auto-discovery.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

home-assistant[bot]

This comment was marked as resolved.

@home-assistant

This comment was marked as resolved.

@home-assistant home-assistant bot marked this pull request as draft May 12, 2024 19:07
home-assistant[bot]

This comment was marked as resolved.

home-assistant[bot]

This comment was marked as resolved.

@Nebula83 Nebula83 marked this pull request as ready for review October 21, 2024 20:27
tests/components/onkyo/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/onkyo/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/onkyo/test_config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/onkyo/strings.json Outdated Show resolved Hide resolved
homeassistant/components/onkyo/strings.json Outdated Show resolved Hide resolved
Nebula83 and others added 5 commits October 22, 2024 20:39
Co-authored-by: Artur Pragacz <49985303+arturpragacz@users.noreply.github.com>
Co-authored-by: Artur Pragacz <49985303+arturpragacz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onkyo integration does not allow unique_id with individual configuration
10 participants