-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock closed issues/prs #6419
Lock closed issues/prs #6419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think HoloViews is going to be the real test for this as Lumen doesn't have real users yet and not a deep Github history.
steps: | ||
- uses: dessant/lock-threads@v5 | ||
with: | ||
issue-inactive-days: "100" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, where does 100 come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I recall correctly, the default is 365, which was too high. So I talked with someone (Philipp?), and we agreed that three months seems right, and three months is around 100 days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I will merge this tomorrow if there are no objections. |
Same as the one used on Lumen https://github.com/holoviz/lumen/blob/main/.github/workflows/lock.yaml
For now, it is set to run every hour, every day, until the backlog is completed, at which point I will change it to run each Tuesday night.