Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock closed issues/prs #6419

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Lock closed issues/prs #6419

merged 1 commit into from
Oct 23, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 22, 2024

Same as the one used on Lumen https://github.com/holoviz/lumen/blob/main/.github/workflows/lock.yaml

For now, it is set to run every hour, every day, until the backlog is completed, at which point I will change it to run each Tuesday night.

@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Oct 22, 2024
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think HoloViews is going to be the real test for this as Lumen doesn't have real users yet and not a deep Github history.

steps:
- uses: dessant/lock-threads@v5
with:
issue-inactive-days: "100"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, where does 100 come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, the default is 365, which was too high. So I talked with someone (Philipp?), and we agreed that three months seems right, and three months is around 100 days.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hoxbro hoxbro requested a review from ahuang11 October 22, 2024 08:33
@hoxbro
Copy link
Member Author

hoxbro commented Oct 22, 2024

I will merge this tomorrow if there are no objections.

@hoxbro hoxbro merged commit 621b3a4 into main Oct 23, 2024
8 checks passed
@hoxbro hoxbro deleted the lock_closed branch October 23, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants