Apply suggestions from code review

Commit suggestions Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
holoviz · Oct 21, 2024 · a75a438 · a75a438
1 parent ea158fe
commit a75a438
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/holoviews/plotting/bokeh/callbacks.py b/holoviews/plotting/bokeh/callbacks.py
@@ -625,7 +625,7 @@ def initialize(self, plot_id=None):
         self._popup_position = stream.popup_position
         self._panel = Panel(
             position=XY(x=np.nan, y=np.nan),
-            anchor=stream.popup_anchor or POPUP_POSITION_ANCHOR.get(self._popup_position, 'top_left'),
+            anchor=stream.popup_anchor or POPUP_POSITION_ANCHOR[self._popup_position],
             elements=[close_button],
             visible=False,
             styles={"zIndex": "1000"},
@@ -1246,7 +1246,7 @@ def _watch_position(self):
                 }
                 if (!xs || !ys) { return; }
 
-                let minX = null, maxX = null, minY = null, maxY = null;
+                let minX, maxX, minY, maxY;
 
                 for (const i of indices) {
                     const tx = xs[i];

diff --git a/holoviews/streams.py b/holoviews/streams.py
@@ -1266,7 +1266,7 @@ class LinkedStream(Stream):
     supplying stream data.
     """
 
-    def __init__(self, linked=True, popup=None, popup_position=POPUP_POSITIONS[0], popup_anchor=None, **params):
+    def __init__(self, linked=True, popup=None, popup_position="top_right", popup_anchor=None, **params):
         if popup_position not in POPUP_POSITIONS:
             raise ValueError(
                 f"Invalid popup_position: {popup_position!r}; "