Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps (and remove inner_cotton and excoveralls) #75

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adamu
Copy link

@adamu adamu commented Jul 21, 2024

This PR performs some maintenance tasks:

  1. Updated CI to run on the latest versions of Erlang and Elixir + bump actions versions
  2. Updated dependencies
  3. Removed unnecessary dependencies

About inner_cotton and excoveralls

I understand the maintainer developed inner_cotton, so this may be controversial. The reason I removed it is because there were some compiler errors with credo and ssl_verify_fun that were fixed by updating their versions, which was easier to do without first updating the upstream inner_cotton dependency. I think more dependencies adds fragility to a project, and this is a very simple library, so would benefit from as few dependencies as possible. In this case, I replaced inner_cotton by using credo and dialyxir directly, and also made the necessary update to ssl_verify_fun.

I removed excoveralls, because the coverage was only 40% anyway, so I think the dependency was adding only a maintenance burden for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant