Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel' and sequential' that take a generator of commands #380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markus1189
Copy link
Contributor

More general than the unticked version that only takes a list and uses
Gen.element to choose one.

This allows you to, for example, use Gen.frequency to generate commands with different weights.

More general than the unticked version that only takes a list and uses
`Gen.element` to choose one.
@markus1189 markus1189 marked this pull request as ready for review May 6, 2020 09:40
@markus1189
Copy link
Contributor Author

Does this have a chance of being merged?

@ocharles
Copy link
Contributor

ocharles commented Jan 6, 2021

This looks like a good addition to me. Hopefully we can get it in in some form (but I'm not a maintainer, so I won't be able to help there).

@HuwCampbell
Copy link
Member

I meant to comment about this earlier sorry.

I don't think there's anything really wrong with this, but, I feel we should fixup Gen.recursive and use the solution to that here as well instead.

At the moment, the docs for Gen.recursive say it can be used with frequency as well as choice. Unfortunately it's a lie; but it is possible to make it so using overlapping instances and some trickery.

As there's a hacky solution, I feel there's probably a good solution for both of these.

@jacobstanley jacobstanley force-pushed the master branch 2 times, most recently from 4139585 to c228279 Compare May 22, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants