optimize Dockerfile using multi-stage builds

hathora · Apr 10, 2024 · a883f85 · a883f85
1 parent 1c062f3
commit a883f85
Show file tree

Hide file tree

Showing 10 changed files with 130 additions and 64 deletions.
diff --git a/examples/avalon/Dockerfile b/examples/avalon/Dockerfile
@@ -1,18 +1,24 @@
-FROM node:18.18-alpine
-
-RUN apk add --update git
-
-# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
-RUN apk add --no-cache libc6-compat
-RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@0.12.1
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data
 

diff --git a/examples/boggle/Dockerfile b/examples/boggle/Dockerfile
@@ -1,18 +1,24 @@
-FROM node:18.18-alpine
-
-RUN apk add --update git
-
-# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
-RUN apk add --no-cache libc6-compat
-RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@0.12.1
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data
 

diff --git a/examples/chat/Dockerfile b/examples/chat/Dockerfile
@@ -1,18 +1,24 @@
-FROM node:18.18-alpine
-
-RUN apk add --update git
-
-# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
-RUN apk add --no-cache libc6-compat
-RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@0.12.1
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data
 

diff --git a/examples/chess/Dockerfile b/examples/chess/Dockerfile
@@ -1,18 +1,24 @@
-FROM node:18.18-alpine
-
-RUN apk add --update git
-
-# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
-RUN apk add --no-cache libc6-compat
-RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@0.12.1
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data
 

diff --git a/examples/codenames/Dockerfile b/examples/codenames/Dockerfile
@@ -1,18 +1,24 @@
-FROM node:18.18-alpine
-
-RUN apk add --update git
-
-# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
-RUN apk add --no-cache libc6-compat
-RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@0.12.1
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data
 

diff --git a/examples/poker/Dockerfile b/examples/poker/Dockerfile
@@ -1,18 +1,24 @@
-FROM node:18.18-alpine
-
-RUN apk add --update git
-
-# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
-RUN apk add --no-cache libc6-compat
-RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@0.12.1
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data
 

diff --git a/examples/pong/Dockerfile b/examples/pong/Dockerfile
@@ -1,18 +1,24 @@
-FROM node:18.18-alpine
-
-RUN apk add --update git
-
-# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
-RUN apk add --no-cache libc6-compat
-RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@0.12.1
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data
 

diff --git a/examples/rock-paper-scissor/Dockerfile b/examples/rock-paper-scissor/Dockerfile
@@ -1,18 +1,24 @@
-FROM node:18.18-alpine
-
-RUN apk add --update git
-
-# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
-RUN apk add --no-cache libc6-compat
-RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@0.12.1
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data
 

diff --git a/examples/uno/Dockerfile b/examples/uno/Dockerfile
@@ -1,18 +1,24 @@
-FROM node:18.18-alpine
-
-RUN apk add --update git
-
-# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
-RUN apk add --no-cache libc6-compat
-RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@0.12.1
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data
 

diff --git a/templates/base/Dockerfile.hbs b/templates/base/Dockerfile.hbs
@@ -1,12 +1,24 @@
-FROM node:18
+FROM node:18.18-alpine as build
 
 WORKDIR /app
 
+RUN apk add --update git
+
 COPY . .
 
 RUN npm i -g hathora@{{ hathoraVersion }}
 RUN npx hathora build --only server
 
+FROM node:18.18-alpine
+
+WORKDIR /app
+
+# https://github.com/uNetworking/uWebSockets.js/discussions/346#discussioncomment-1137301
+RUN apk add --no-cache libc6-compat
+RUN ln -s /lib/libc.musl-x86_64.so.1 /lib/ld-linux-x86-64.so.2
+
+COPY --from=build /app/server/dist server/dist
+
 ENV NODE_ENV=production
 ENV DATA_DIR=/app/data