fix: insecure host key #254
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the knownhosts package to validate the host key. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhancements to the
EsxiDriverin thebuilder/vmware/common/driver_esxi.gofile to improve security by using known host key verification. The most important changes involve importing theknownhostspackage and updating the SSH connection configuration to use a known hosts file.knownhostspackage to enable host key verification.connectfunction to use a known hosts file for host key verification instead of ignoring host keys.Reference
https://github.com/hashicorp/packer-plugin-vmware/security/code-scanning/7