Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller.mdx - public_cluster_addr #5151

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

vanphan24
Copy link
Contributor

Updating public_cluster_addr to indicate that it is used if a load balancer is used for controllers. Also added a note about not including https:// and http:// in the address

Updating public_cluster_addr to indicate that it is used if a load balancer is used for controllers. Also added a note about not including https:// and http:// in the address
@vanphan24 vanphan24 added the backport/website Backport changes to `stable-website` and the latest release-branch label Oct 7, 2024
@vanphan24 vanphan24 requested a review from a team as a code owner October 7, 2024 17:11
Copy link
Collaborator

@stellarsquall stellarsquall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! these changes look good to me

Copy link
Contributor

@Dan-Heath Dan-Heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update Van and Irena!

@Dan-Heath Dan-Heath merged commit 7bef893 into main Oct 8, 2024
6 of 7 checks passed
@Dan-Heath Dan-Heath deleted the vanphan24-patch-1 branch October 8, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/website Backport changes to `stable-website` and the latest release-branch docs/configuration website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants