Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure ipv6 compatibility for cli and config #5110

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ddebko
Copy link
Collaborator

@ddebko ddebko commented Sep 16, 2024

Summary

This PR ensures that the CLI commands inputed by the user can include field values that contain IPv6 addresses. This PR also ensures that the config file may contain field values that have IPv6 addresses.

Copy link
Collaborator

@kheina kheina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had one question

internal/cmd/config/config.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kheina kheina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddebko ddebko merged commit 29efd5e into main Sep 20, 2024
58 of 62 checks passed
@ddebko ddebko deleted the ddebko-ipv6-cmd-tests branch September 20, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants