chore(e2e): Remove tparse #4326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moduli
force-pushed
the
moduli-e2e-remove-tparse
branch
from
5d4c8b7
to
f8d16ae
Compare
moduli
force-pushed
the
moduli-e2e-remove-tparse
branch
from
6fb0203
to
d1b1906
Compare
johanbrandhorst
approved these changes
Feb 5, 2024
moduli
force-pushed
the
moduli-e2e-remove-tparse
branch
from
d1b1906
to
e379896
Compare
moduli
added a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
tparsein the e2e test suite (it was only being used in AWS-based enos scenarios). Doing so also removes the need to use the go cache, saving some time in CI (~20 seconds)Note on the below times:
setuphas the most time-savingsBefore:
https://github.com/hashicorp/boundary/actions/runs/7786366940/job/21231734235
After:
https://github.com/hashicorp/boundary/actions/runs/7763621684/job/21176203742