Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 일정 CRUD #5 #6

Merged
merged 11 commits into from
Aug 30, 2023
Merged

[FEAT] 일정 CRUD #5 #6

merged 11 commits into from
Aug 30, 2023

Conversation

hisemsem
Copy link
Contributor

@hisemsem hisemsem commented Jul 16, 2023

[#5] 일정 CRUD

🛠️ 작업 내용

📢 to 리뷰어

  • 컨벤션 및 MVC 패턴 제대로 지켰는지 확인 부탁드리겠습니다.

@PostMapping //@PostMapping 애너테이션을 통해 HTTP POST 요청을 수신
public Schedule saveSchedule(@RequestBody Schedule schedule){
//@RequestBody 애너테이션을 사용하여 요청 본문에 있는 데이터를 Schedule 객체로 변환함
return scheduleService.saveSchedule(schedule);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try-catch형태로 진행 부탁드리며 BaseResponse로 return 해주세요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다!

@devyubin devyubin temporarily deployed to production August 17, 2023 13:44 — with GitHub Actions Inactive
@devyubin devyubin temporarily deployed to production August 17, 2023 14:20 — with GitHub Actions Inactive
@hisemsem hisemsem temporarily deployed to production August 30, 2023 05:00 — with GitHub Actions Inactive
@devyubin devyubin merged commit 114d98c into main Aug 30, 2023
3 checks passed
@devyubin devyubin temporarily deployed to production September 14, 2023 12:32 — with GitHub Actions Inactive
@devyubin devyubin deleted the feature/schedule branch September 14, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants