fix(topup): reset old keeper registry allowance

hackbg · May 29, 2024 · 5c56e59 · 5c56e59
1 parent afde372
commit 5c56e59
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/contracts/DssVestTopUp.sol b/contracts/DssVestTopUp.sol
@@ -191,6 +191,7 @@ contract DssVestTopUp is IUpkeepRefunder, INetworkTreasury, Ownable {
 
     function setKeeperRegistry(address _keeperRegistry) external onlyOwner {
         if (_keeperRegistry == address(0)) revert InvalidParam("KeeperRegistry");
+        TransferHelper.safeApprove(linkToken, address(keeperRegistry), 0);
         keeperRegistry = KeeperRegistryLike(_keeperRegistry);
         TransferHelper.safeApprove(linkToken, _keeperRegistry, type(uint256).max);
         emit KeeperRegistrySet(_keeperRegistry);

diff --git a/test/unit/DssVestTopUp.test.ts b/test/unit/DssVestTopUp.test.ts
@@ -428,6 +428,13 @@ describe("DssVestTopUp", function () {
       ).to.eq(ethers.constants.MaxUint256);
     });
 
+    it("should reset link token allowance to the old keeper registry", async function () {
+      await topUp.setKeeperRegistry(randomAddress.address);
+      expect(
+        await linkToken.allowance(topUp.address, keeperRegistryMock.address)
+      ).to.eq(0);
+    });
+
     it("should set upkeep id", async function () {
       const newUpkeepId = 1;
       await topUp.setUpkeepId(newUpkeepId);