Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where merge tag would not use already generated data and retrieve a new response instad. #21

Closed
wants to merge 1 commit into from

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2393974832/56193/

Summary

The OpenAI feed maps the result to a field and a merge tag, the responses shown in the field and merge tag are different. On the get_merge_tag_replacement method, we regenerate the response. Instead we should be looking for an already generated response, and if found we just use that.

BEFORE: (slightly cropped screenshots to depict the crux of the issue)
Screenshot 2023-10-20 at 5 23 13 PM

AFTER:
Screenshot 2023-10-20 at 5 23 49 PM

Checklist

  • Updated customer telling them that a fix/addition is in the works.
  • Added/Improved Cypress tests or a note under Summary why tests are not included in the PR.
  • Added a link to this PR in the Help Scout ticket(s) in the form of a note
  • Sent a packed build

@saifsultanc saifsultanc added the bug Something isn't working label Oct 20, 2023
@saifsultanc
Copy link
Contributor Author

@claygriffiths The only issue that, as you can see, is the formatting of the text on retrieval is broken.

@claygriffiths
Copy link
Contributor

Closing in favor of ad8f5b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants